Re: [PATCH 1/5] perf: Disallow mmap() on per-task inherited events

From: Paul Mackerras
Date: Mon May 24 2010 - 21:07:22 EST


On Tue, May 18, 2010 at 03:32:59PM +0200, Peter Zijlstra wrote:

> Since we now have working per-task-per-cpu events for a while,
> disallow mmap() on per-task inherited events. Those things were
> a performance problem anyway, and doing away with it allows
> us to optimize the buffer somewhat by assuming there is only a single
> writer.

This also disallows user-space access to hardware counter for this
event -- which is arguably OK, since doing the userspace read would
give a different answer to read() on the event fd, as the read() sums
up all the child counters for us. Nevertheless, I think this
side-effect is worth mentioning.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/