Re: [dm-devel] [PATCH v3 3/3] dm: lookup devices by path withname_to_dev_t

From: Alasdair G Kergon
Date: Mon May 24 2010 - 11:07:43 EST


On Mon, May 24, 2010 at 09:44:07AM -0500, Will Drewry wrote:
> fwiw, the only reason for the copy was because |path| is a
> const in the function but not when passed to name_to_dev_t.
> I wasn't sure what the preferred practice was so I just duped
> the data needed.

Well check that it is treated as 'const' and send a separate patch to
the maintainer to add const, perhaps? If it isn't const (why would
that be?), then yes we'd need to copy it.

Alasdair

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/