Re: [PATCH] x86: Export tsc related information in sysfs

From: Venkatesh Pallipadi
Date: Sat May 15 2010 - 10:37:47 EST


On Sat, May 15, 2010 at 5:35 AM, Jaswinder Singh Rajput
<jaswinderlinux@xxxxxxxxx> wrote:
> Hello,
>> +
>> +static int __init init_tsc_sysfs(void)
>> +{
>> +       int err, i = 0;
>> +
>> +       err = sysdev_class_register(&tsc_sysclass);
>> +       if (err)
>> +               return err;
>> +
>> +       err = sysdev_register(&device_tsc);
>> +       if (err)
>> +               goto fail;
>
> fail will call sysdev_unregister(&device_tsc) which is not
> appropriate, please fix this goto.
>

Thanks for catching this. Will fix this in the patch refresh.

Thanks,
Venki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/