Re: [PATCH] mm: Consider the entire user address space during node migration

From: KOSAKI Motohiro
Date: Sat May 15 2010 - 10:31:27 EST


Hi

Mysteriously, I haven't receive original post.
So now I'm guessing you acked following patch.

http://lkml.org/lkml/2010/5/14/393

but I don't think it is correct.

> - check_range(mm, mm->mmap->vm_start, TASK_SIZE, &nmask,
> + check_range(mm, mm->mmap->vm_start, TASK_SIZE_MAX, &nmask,
> flags | MPOL_MF_DISCONTIG_OK, &pagelist);

Because TASK_SIZE_MAX is defined on x86 only. Why can we ignore other platform?
Please put following line anywhere.

#define TASK_SIZE_MAX TASK_SIZE


But this patch is conceptually good. if it fixes the bug. I'll ack gladly.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/