Re: [PATCH] staging/comedi: new Kconfig and Makefiles, driversgrouped by bustype.

From: Alexander Kurz
Date: Sat May 15 2010 - 08:09:12 EST



On Fri, 14 May 2010, Frank Mori Hess wrote:

> On Friday 14 May 2010, Greg KH wrote:
> > Wow. Is this something that we really want? That's a lot of new
> > Kconfig options, and while it seems like it makes sense, I would like to
> > get the comedi developers opinion here.
>
> It doesn't matter to me how granular the Kconfig stuff is. Personally, the
> only thing I tend to do is disable are the pcmcia drivers as a group on
> desktop machines. Also, I noticed in the patch it includes the 8255
> module as part of the PCI and ISA groups, but not PCMCIA. But it is used
> by some of the PCMCIA drivers as well.
>
Hm, I cannot see a build-dependancy from any of the PCMCIA-Modules
to 8255.c. All PCMCIA-modules do build and load fine without compiling
8255.c. There is a dependancy from das08_cs (PCMCIA) to das08 (ISA) via
config COMEDI_DAS08_CS select COMEDI_DAS08.
This will lead to a hidden select of COMEDI_DAS08 when
COMEDI_ISA_DRIVERS is not enabled.
Is there something that I have missed?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/