Re: [PATCH] anon_inode: set S_IFREG on the anon_inode

From: Eric Paris
Date: Fri May 14 2010 - 16:27:11 EST


On Fri, 2010-05-14 at 21:23 +0100, Al Viro wrote:
> On Fri, May 14, 2010 at 04:05:59PM -0400, Eric Paris wrote:
> > anon_inode_mkinode() sets inode->i_mode = S_IRUSR | S_IWUSR; This means
> > that (inode->i_mode & S_IFMT) == 0. This trips up some SELinux code that
> > needs to determine if a given inode is a regular file, a directory, etc.
> > The easiest solution is to just make sure that the anon_inode also sets
> > S_IFREG.
>
> How urgent that one is? It is obvious enough, so I could include it into
> the pull request for -final, but...

printk spam. No hurry. Probably should have put that in the commit
message.

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/