Re: [PATCH] perf/trace: use read() instead of lseek() intrace_event_read.c:skip()

From: Borislav Petkov
Date: Fri May 14 2010 - 12:13:02 EST


From: Tom Zanussi <tzanussi@xxxxxxxxx>
Date: Tue, May 04, 2010 at 11:02:10PM -0500

Hi,

> Here's a small fix for a problem affecting live-mode, introduced in the
> past day or so:
>
> root@tropicana:~# perf trace rwtop
> perf trace started with Perl
> script /root/libexec/perf-core/scripts/perl/rwtop.pl
>
> Fatal: did not read header event
>
> commit d00a47cce569a3e660a8c9de5d57af28d6a9f0f7 added a skip()
> function to skip over e.g. header_page, but this doesn't work for live
> mode. This patch re-implements skip() to use read() instead of
> lseek() to fix that.
>
> Signed-off-by: Tom Zanussi <tzanussi@xxxxxxxxx>

has this one landed in any tree in the meantime?

tip/perf/core doesn't have it.

--
Regards/Gruss,
Boris.

Operating Systems Research Center
Advanced Micro Devices, Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/