Re: [RFC, 3/7] NUMA hotplug emulator

[Haicheng Li]

Greg KH wrote:
> > Add a sysfs entry "probe" under /sys/devices/system/node/:
> >
> >  - to show all fake offlined nodes:
> >     $ cat /sys/devices/system/node/probe
> >
> >  - to hotadd a fake offlined node, e.g. nodeid is N:
> >     $ echo N > /sys/devices/system/node/probe
>
> As you are trying to add a new sysfs file, please create the matching
> Documentation/ABI/ file as well.

Yes, we missed it. thank you.

> Also note that sysfs files are "one value per file", which I don't think
> this file follows, right?

Sorry, we didn't make the descriptions clear enough.
It should follow "one value per file". It intends to show acceptable parameters.

For example, if we have 4 fake offlined nodes, like node 2-5, then:
  $ cat /sys/devices/system/node/probe
    2-5

Then user hotadds node3 to system:
  $ echo 3 > /sys/devices/system/node/probe
  $ cat /sys/devices/system/node/probe
    2,4-5

-haicheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/