Re: [RFC, 3/7] NUMA hotplug emulator

From: Greg KH
Date: Thu May 13 2010 - 12:59:39 EST


On Thu, May 13, 2010 at 07:48:35PM +0800, Shaohui Zheng wrote:
> Userland interface to hotplug-add fake offlined nodes.

Why include 2 copies of the patch in one email?

> Add a sysfs entry "probe" under /sys/devices/system/node/:
>
> - to show all fake offlined nodes:
> $ cat /sys/devices/system/node/probe
>
> - to hotadd a fake offlined node, e.g. nodeid is N:
> $ echo N > /sys/devices/system/node/probe

As you are trying to add a new sysfs file, please create the matching
Documentation/ABI/ file as well.

Also note that sysfs files are "one value per file", which I don't think
this file follows, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/