Re: [PATCH 4/4] msi-laptop: Add i8042 filter to sync sw state with BIOS when function key pressed

From: Joey Lee
Date: Thu May 13 2010 - 07:53:16 EST


Hi Dmitry,

Thank's for your review.

æ åï2010-05-13 æ 00:52 -0700ïDmitry Torokhov æåï
> On Wed, May 12, 2010 at 11:56:47AM -0700, Greg KH wrote:
> > static int __init msi_init(void)
> > @@ -819,6 +875,7 @@ static void __exit msi_cleanup(void)
> > platform_driver_unregister(&msipf_driver);
> > backlight_device_unregister(msibl_device);
> >
> > + i8042_remove_filter(msi_laptop_i8042_filter);
>
> You also need cancel_delayed_work_sync() here. Sorry for not noticing
> this before.
>

Yes, you are right, need add cancel_delayed_work_sync().

Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/