Re: [PATCH 11/12] x86 rwsem: down_read_unfair implementation

From: David Howells
Date: Wed May 12 2010 - 09:10:10 EST

Next message: David Howells: "Re: [PATCH 12/12] Use down_read_unfair() for /sys/<pid>/exe and /sys/<pid>/maps files"
Previous message: Jamie Lokier: "Re: [BUG] bug when enabling VM DEBUG"
In reply to: David Howells: "Re: [PATCH 09/12] generic rwsem: implement down_read_unfair"
Next in thread: David Howells: "Re: [PATCH 12/12] Use down_read_unfair() for /sys/<pid>/exe and /sys/<pid>/maps files"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Michel Lespinasse <walken@xxxxxxxxxx> wrote:

> #define RWSEM_WAITING_BIAS (-RWSEM_ACTIVE_MASK-1)
> #define RWSEM_ACTIVE_READ_BIAS RWSEM_ACTIVE_BIAS
> +#define RWSEM_ACTIVE_WRITE_BIAS (2 * RWSEM_WAITING_BIAS + \
> + RWSEM_ACTIVE_BIAS)

These are getting a bit meaningless. Can you replace them with hex numbers to
make it clearer what's going on? Putting a worked example in the patch
description would be good too.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: David Howells: "Re: [PATCH 12/12] Use down_read_unfair() for /sys/<pid>/exe and /sys/<pid>/maps files"
Previous message: Jamie Lokier: "Re: [BUG] bug when enabling VM DEBUG"
In reply to: David Howells: "Re: [PATCH 09/12] generic rwsem: implement down_read_unfair"
Next in thread: David Howells: "Re: [PATCH 12/12] Use down_read_unfair() for /sys/<pid>/exe and /sys/<pid>/maps files"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]