Re: [PATCH 4/8] x86/mrst: change clock selection logic to supportmedfield

[Thomas Gleixner]

On Tue, 11 May 2010, Alan Cox wrote:

> > > +	pr_debug("cpuid result %x\n", regs[CR_EAX]);
> > > +	pr_info("Moorestown CPU %s identified\n",
> > > +		(mrst_cpu_chip == MRST_CPU_CHIP_LINCROFT) ?
> > > +		"Lincroft" : "Penwell");
> > 
> >   Are we going to add one of those for each new family ? This is
> >   really redundant bloat with no value.
> > 
> > > +	return mrst_cpu_chip;
> 
> From the driver side we need this value determined and visible to the
> drivers because some things like the IPC interface need to know rather
> than getting the cpuid magic replicated around.

Ok. That makes sense. Is there more what MRST drivers need to know ?

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/