Re: [PATCH 05/25] lmb: Factor the lowest level alloc function

From: Thomas Gleixner
Date: Tue May 11 2010 - 08:31:58 EST


On Mon, 10 May 2010, Benjamin Herrenschmidt wrote:
>
> @@ -396,33 +406,24 @@ u64 __init __lmb_alloc_base(u64 size, u64 align, u64 max_addr)
> if (max_addr == LMB_ALLOC_ANYWHERE)
> max_addr = LMB_REAL_LIMIT;
>
> + /* Pump up max_addr */
> + if (max_addr == LMB_ALLOC_ANYWHERE)
> + max_addr = ~(u64)0;
> +

That if is pretty useless as you set max_addr to LMB_REAL_LIMIT
right above.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/