Re: [rfc] x86,perf: P4 PMU -- use hash for p4_get_escr_idx

From: Lin Ming
Date: Tue May 11 2010 - 03:07:31 EST


On Tue, 2010-05-11 at 14:47 +0800, Lin Ming wrote:
> On Tue, 2010-05-11 at 14:41 +0800, Ingo Molnar wrote:
> > * Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > >
> > > * Lin Ming <ming.m.lin@xxxxxxxxx> wrote:
> > >
> > > > On Mon, 2010-05-10 at 23:27 +0800, Cyrill Gorcunov wrote:
> > > > > Hi Ming,
> > > > >
> > > > > could you give this patch a shot if possible? Compile
> > > > > tested only. I would appreciate review and complains
> > > > > as well :) I know you're busy with other perf task
> > > > > so there is no hurry. Just to share the patch as early
> > > > > as possible.
> > > >
> > > > Hi,
> > > >
> > > > I'm going to test this patch, but current tip/master(c6661c5) seems has
> > > > problem.
> > >
> > > Does reverting 4fd38e4595e2f6c9d27732c042a0e16b2753049c help?
> >
> > If not then it would be nice if you could try to do a bisection.
>
> Yes, it's the commit 4fd38e45 causes the regression.

Cyrill,

After reverting commit 4fd38e45, this patch works well.

Lin Ming

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/