Re: [PATCH 2/2] cpuidle: Add a repeating pattern detector to themenu governor

[Andrew Morton]

On Mon, 10 May 2010 18:27:46 -0700 Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> On Mon, 10 May 2010 14:38:50 -0700
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > > +	if (avg && stddev < STDDEV_THRESH)
> > > +		data->predicted_us = avg;
> > > +}
> > 
> > You got lucky there, because INTERVALS is a power of two.  If someone
> > changes INTERVALS to 7, this code will ask for __udivdi3 and won't
> > link on i364.
> 
> yeah you'd think it almost isn't an accident ;-)

If it was deliberate the code would read

	avg >>= INTERVALS_SHIFT;

:-p
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/