Re: [PATCH] Staging: wlags49_h2: fixed C99 comments style issues in wl_profile.c

From: Prashant Shah
Date: Mon May 10 2010 - 12:52:28 EST


Hi,

>> -//     } else {
>> -//             this should not be debug time info, it is an enduser data entry error ;?
>> -//             DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS);
>> +/*     } else {
>> +               this should not be debug time info, it is an enduser data entry error ;?
>> +               DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS); */
> In such case you have lost the internal comments. I think it should look like
> /*
> } else {
> /* ... */

Sent a new patch. I tried the nested comments but gcc wont handle it
correctly (maybe I am wrong here). Please discard the old patch and
use this new one.

-// } else {
-// this should not be debug time info, it is an enduser
data entry error ;?
-// DBG_WARNING(DbgInfo, "%s invalid; will be ignored\n",
PARM_NAME_MICROWAVE_ROBUSTNESS);
+ /* } else { */
+ /* this should not be debug time info, it is an
enduser data entry error ;? */
+ /* DBG_WARNING(DbgInfo, "%s invalid; will be
ignored\n", PARM_NAME_MICROWAVE_ROBUSTNESS); */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/