Re: [PATCH 12/25] lmb: Move lmb arrays to static storage in lmb.c and make their size a variable

From: Paul Mundt
Date: Mon May 10 2010 - 06:45:35 EST


On Mon, May 10, 2010 at 07:38:46PM +1000, Benjamin Herrenschmidt wrote:
> diff --git a/include/linux/lmb.h b/include/linux/lmb.h
> index 27c2386..e575801 100644
> --- a/include/linux/lmb.h
> +++ b/include/linux/lmb.h
> @@ -18,7 +18,7 @@
>
> #include <asm/lmb.h>
>
> -#define MAX_LMB_REGIONS 128
> +#define INIT_LMB_REGIONS 128
>
> struct lmb_region {
> phys_addr_t base;

Perhaps it would be better to weight this against MAX_ACTIVE_REGIONS for
the ARCH_POPULATES_NODE_MAP case? The early node map is already using
that size, at least.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/