Re: [PATCH 2/2] vgacon: use request_region(), not request_resource(),to set BUSY

From: Linus Torvalds
Date: Tue May 04 2010 - 15:11:23 EST




On Tue, 4 May 2010, Bjorn Helgaas wrote:
>
> Drivers normally use request_region() to mark the region busy so it won't
> be used by anybody else. Previously, we used request_resource(), which
> doesn't mark the VGA regions busy.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>

Hmm. I don't object, but unless there is some crazy regression, there's no
way I will take something like this outside the merge window. Who knows
what odd frame buffer driver is out there that just depended on the fact
that it could also register that VGA area?

Probably no such thing exists, but it's why I want these kinds of things
during the merge window. And obviously preferably through something like
the PCI merge tree, but that's a different issue.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/