Re: [PATCH 13/22] KVM: X86: Add kvm_read_guest_page_tdp function

From: Avi Kivity
Date: Tue Apr 27 2010 - 09:40:45 EST


On 04/27/2010 03:42 PM, Avi Kivity wrote:

+{
+ gfn_t real_gfn;
+ gpa_t gpa;
+
+ *error = 0;
+ gpa = gfn<< PAGE_SHIFT;

This overflows too :)

Use gfn_to_gpa().

+ real_gfn = mmu->translate_gpa(vcpu, gpa, error);

Overflow: sizeof(gpa) > sizeof(gfn).

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/