Re: [BUGFIX][PATCH] memcg rcu lock fix v3

[Paul E. McKenney]

On Sat, Apr 24, 2010 at 11:08:05AM +0900, KAMEZAWA Hiroyuki wrote:
> On Fri, 23 Apr 2010 12:34:06 -0700
> "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Fri, Apr 23, 2010 at 01:03:49PM +0900, KAMEZAWA Hiroyuki wrote:
> > > On Fri, 23 Apr 2010 12:58:14 +0900
> > > KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> > > 
> > > > On Fri, 23 Apr 2010 11:55:16 +0800
> > > > Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
> > > > 
> > > > > Li Zefan wrote:
> > > > > > KAMEZAWA Hiroyuki wrote:
> > > > > >> On Fri, 23 Apr 2010 11:00:41 +0800
> > > > > >> Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
> > > > > >>
> > > > > >>> with CONFIG_PROVE_RCU=y, I saw this warning, it's because
> > > > > >>> css_id() is not under rcu_read_lock().
> > > > > >>>
> > > > > >> Ok. Thank you for reporting.
> > > > > >> This is ok ? 
> > > > > > 
> > > > > > Yes, and I did some more simple tests on memcg, no more warning
> > > > > > showed up.
> > > > > > 
> > > > > 
> > > > > oops, after trigging oom, I saw 2 more warnings:
> > > > > 
> > > > 
> > > > Thank you for good testing.
> > > v3 here...sorry too rapid posting...
> > > 
> > > ==
> > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> > 
> > I have queued this, thank you all!
> > 
> > However, memcg_oom_wake_function() does not yet exist in the tree
> > I am using, and is_target_pte_for_mc() has changed.  I omitted the
> > hunk for memcg_oom_wake_function() and edited the hunk for
> > is_target_pte_for_mc().
> > 
> Ok, memcg_oom_wake_function is for -mm. I'll prepare another patch for -mm.
> 
> 
> > I have queued this for others' testing, but if you would rather carry
> > this patch up the memcg path, please let me know and I will drop it.
> > 
> I think it's ok to be fixed by your tree. I'll look at memcg later and
> fix remaining things.

Sounds good!

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/