Re: [PATCH 1/2] Make WMI be selected automatically when needed

[Matthew Garrett]

On Fri, Apr 23, 2010 at 09:51:54PM +0200, Éric Piel wrote:

> Currently there are 2 modules which select ACPI_WMI and 4 which depend
> on it. There are 7 modules which select BACKLIGHT_CLASS_DEVICE and as
> many which depend on it. Making usage of the select functionality all
> the time would avoid these inconsistencies.

Using select for ACPI_WMI is pretty clearly wrong since it fails in 
cases where ACPI isn't enabled. But I don't think the appropriate way to 
handle that is to encode the dependency between ACPI_WMI and ACPI 
multiple times - they should just be switched to depend on it instead.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/