Re: [PATCH] procfs: fix tid fdinfo

[Andrew Morton]

On Fri, 23 Apr 2010 17:40:07 +0200
Jerome Marchand <jmarchan@xxxxxxxxxx> wrote:

> Correct the file_operations struct in fdinfo entry of tid_base_stuff[].
> 
> Signed-off-by: Jerome Marchand <jmarchan@xxxxxxxxxx>
> ---
>  base.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 7621db8..8418fcc 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2909,7 +2909,7 @@ out_no_task:
>   */
>  static const struct pid_entry tid_base_stuff[] = {
>  	DIR("fd",        S_IRUSR|S_IXUSR, proc_fd_inode_operations, proc_fd_operations),
> -	DIR("fdinfo",    S_IRUSR|S_IXUSR, proc_fdinfo_inode_operations, proc_fd_operations),
> +	DIR("fdinfo",    S_IRUSR|S_IXUSR, proc_fdinfo_inode_operations, proc_fdinfo_operations),
>  	REG("environ",   S_IRUSR, proc_environ_operations),
>  	INF("auxv",      S_IRUSR, proc_pid_auxv),
>  	ONE("status",    S_IRUGO, proc_pid_status),

hm, the code's been like that for over a year.  What are the
user-visible effects of the bug, and of this change?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/