Re: [PATCH 4/10] KVM MMU: Move invlpg code out of paging_tmpl.h

[Avi Kivity]

On 04/23/2010 02:27 PM, Avi Kivity wrote:
> On 04/22/2010 09:12 AM, Xiao Guangrong wrote:
> > Using '!sp->role.cr4_pae' replaces 'PTTYPE == 32' and using
> > 'pte_size = sp->role.cr4_pae ? 8 : 4' replaces sizeof(pt_element_t)
> >
> > Then no need compile twice for this code
> I think we should keep it in - kvm_mmu_pte_write() calls back to 
> FNAME(update_pte), we could make the call directly from here speed 
> things up, since we already have the spte and don't need to look it up.

I see you do this in patches 9, 10 - but is it possible to use 
update_pte directly?  I think we'll need to make 
guess_page_from_pte_write() part of paging_tmpl.h (in general anything 
that depends on pte size is better off in paging_tmpl.h).

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/