Re: [PATCH 7/9] PM: Add suspend blocking work.

From: Tejun Heo
Date: Fri Apr 23 2010 - 04:18:21 EST


Hello,

On 04/23/2010 03:08 AM, Arve HjÃnnevÃg wrote:
> Allow work to be queued that will block suspend while it is pending
> or executing. To get the same functionality in the calling code often
> requires a separate suspend_blocker for pending and executing work, or
> additional state and locking.

Hmm... I think this can be implemented as pure wrapper around
workqueue instead of injecting a flag and code into workqueue core.
Adding @fn field to suspend_blocking_work struct and using a custom
work function to call it and then invoke suspend_unblock() should be
enough, right? Oh, dedicated queue functions will be needed too. I
don't think it's wise to meddle with workqueue core code for this.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/