Re: mmotm 2010-04-22-16-38 uploaded

[Valdis . Kletnieks]

On Thu, 22 Apr 2010 16:38:55 PDT, akpm@xxxxxxxxxxxxxxxxxxxx said:
> The mm-of-the-moment snapshot 2010-04-22-16-38 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/

Found this in numa-introduce-numa_mem_id-effective-local-memory-node-id.patch:

+#ifndef cpu_to_mem
+#define cpu_to_mem(cpu)                (void)(cpu),0)
+#endif

The resulting paren mismatch causes an error cascade in 2 other patches:

numa-in-kernel-profiling-use-cpu_to_mem-for-per-cpu-allocations.patch

causes build errors:

  CC      kernel/profile.o
kernel/profile.c: In function â??profile_cpu_callbackâ??:
kernel/profile.c:366: error: void value not ignored as it ought to be
kernel/profile.c:366: warning: left-hand operand of comma expression has no effect
kernel/profile.c:366: warning: statement with no effect
kernel/profile.c:366: error: expected â??;â?? before â??)â?? token
kernel/profile.c:366: error: expected statement before â??)â?? token
kernel/profile.c: In function â??create_hash_tablesâ??:
kernel/profile.c:568: error: void value not ignored as it ought to be
kernel/profile.c:568: error: expected identifier or â??(â?? before numeric constant
make[1]: *** [kernel/profile.o] Error 1
make: *** [kernel] Error 2

numa-slab-use-numa_mem_id-for-slab-local-memory-node.patch causes a whole
raft of issues:

  CC      mm/slab.o
mm/slab.c: In function â??cpuup_canceledâ??:
mm/slab.c:1156: error: void value not ignored as it ought to be
mm/slab.c:1156: error: expected identifier or â??(â?? before numeric constant
mm/slab.c: In function â??cpuup_prepareâ??:
mm/slab.c:1221: error: void value not ignored as it ought to be
mm/slab.c:1221: error: expected identifier or â??(â?? before numeric constant
mm/slab.c: In function â??kmem_cache_initâ??:
mm/slab.c:1506: error: â??numa_nodeâ?? undeclared (first use in this function)
mm/slab.c:1506: error: (Each undeclared identifier is reported only once
mm/slab.c:1506: error: for each function it appears in.)
mm/slab.c:1506: warning: type defaults to â??intâ?? in declaration of â??pscr_ret__â??
mm/slab.c:1506: warning: type defaults to â??intâ?? in declaration of â??type nameâ??
mm/slab.c:1506: warning: cast from pointer to integer of different size
mm/slab.c:1506: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:1506: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:1506: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:1506: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c: In function â??setup_cpu_cacheâ??:
mm/slab.c:2148: error: â??numa_nodeâ?? undeclared (first use in this function)
mm/slab.c:2148: warning: type defaults to â??intâ?? in declaration of â??pscr_ret__â??
mm/slab.c:2148: warning: type defaults to â??intâ?? in declaration of â??type nameâ??

mm/slab.c:2148: warning: cast from pointer to integer of different size
mm/slab.c:2148: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:2148: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:2148: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:2148: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c: In function â??do_drainâ??:
mm/slab.c:2506: error: â??numa_nodeâ?? undeclared (first use in this function)
mm/slab.c:2506: warning: type defaults to â??intâ?? in declaration of â??pscr_ret__â??
mm/slab.c:2506: warning: type defaults to â??intâ?? in declaration of â??type nameâ??
mm/slab.c:2506: warning: cast from pointer to integer of different size
mm/slab.c:2506: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:2506: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:2506: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:2506: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c: In function â??cache_alloc_refillâ??:
mm/slab.c:3039: error: â??numa_nodeâ?? undeclared (first use in this function)
mm/slab.c:3039: warning: type defaults to â??intâ?? in declaration of â??pscr_ret__â??
mm/slab.c:3039: warning: type defaults to â??intâ?? in declaration of â??type nameâ??
mm/slab.c:3039: warning: cast from pointer to integer of different size
mm/slab.c:3039: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:3039: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:3039: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:3039: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c: In function â??cache_flusharrayâ??:
mm/slab.c:3575: error: â??numa_nodeâ?? undeclared (first use in this function)
mm/slab.c:3575: warning: type defaults to â??intâ?? in declaration of â??pscr_ret__â??
mm/slab.c:3575: warning: type defaults to â??intâ?? in declaration of â??type nameâ??
mm/slab.c:3575: warning: cast from pointer to integer of different size
mm/slab.c:3575: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:3575: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:3575: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:3575: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c: In function â??do_tune_cpucacheâ??:
mm/slab.c:4009: error: invalid use of void expression
mm/slab.c:4009: error: too few arguments to function â??alloc_arraycacheâ??
mm/slab.c:4009: warning: left-hand operand of comma expression has no effect
mm/slab.c:4010: warning: left-hand operand of comma expression has no effect
mm/slab.c:4010: warning: left-hand operand of comma expression has no effect
mm/slab.c:4010: warning: statement with no effect
mm/slab.c:4010: error: expected â??;â?? before â??)â?? token
mm/slab.c:4010: error: expected statement before â??)â?? token
mm/slab.c:4031: error: expected â??]â?? before â??)â?? token
mm/slab.c:4031: warning: passing argument 1 of â??spin_lock_irqâ?? from incompatible pointer type
include/linux/spinlock.h:307: note: expected â??struct spinlock_t *â?? but argument is of type â??struct kmem_list3 **â??
mm/slab.c:4031: error: expected â??;â?? before â??]â?? token
mm/slab.c:4031: error: expected statement before â??]â?? token
mm/slab.c:4031: error: expected expression before â??->â?? token
mm/slab.c:4031: error: expected statement before â??)â?? token
mm/slab.c:4032: error: invalid use of void expression
mm/slab.c:4032: error: too many arguments to function â??free_blockâ??
mm/slab.c:4032: error: expected â??;â?? before â??)â?? token
mm/slab.c:4032: error: expected statement before â??)â?? token
mm/slab.c:4033: error: expected â??]â?? before â??)â?? token
mm/slab.c:4033: warning: passing argument 1 of â??spin_unlock_irqâ?? from incompatible pointer type
include/linux/spinlock.h:332: note: expected â??struct spinlock_t *â?? but argument is of type â??struct kmem_list3 **â??
mm/slab.c:4033: error: expected â??;â?? before â??]â?? token
mm/slab.c:4033: error: expected statement before â??]â?? token
mm/slab.c:4033: error: expected expression before â??->â?? token
mm/slab.c:4033: error: expected statement before â??)â?? token
mm/slab.c: In function â??cache_reapâ??:
mm/slab.c:4139: error: â??numa_nodeâ?? undeclared (first use in this function)
mm/slab.c:4139: warning: type defaults to â??intâ?? in declaration of â??pscr_ret__â??
mm/slab.c:4139: warning: type defaults to â??intâ?? in declaration of â??type nameâ??
mm/slab.c:4139: warning: cast from pointer to integer of different size
mm/slab.c:4139: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:4139: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:4139: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
mm/slab.c:4139: warning: type defaults to â??intâ?? in declaration of â??pfo_ret__â??
make[1]: *** [mm/slab.o] Error 1
make: *** [mm] Error 2

Attachment: pgp00000.pgp
Description: PGP signature