Re: [PATCH 2/6] [watchdog] convert touch_softlockup_watchdog totouch_watchdog

From: Don Zickus
Date: Thu Apr 22 2010 - 09:20:50 EST


On Wed, Apr 21, 2010 at 11:46:12PM +0200, Frederic Weisbecker wrote:
> > > Hence I guess we want to keep the current state:
> > >
> > > - touch_nmi_watchdog() = touch softlockup and nmi watchdogs
> > > - touch_softlockup_watchdog() = only touch softlockup watchdog
> >
> > Hmm ok I see what you are saying. A little tweak and I have this
> > compiled-tested only patch that I think satisifies you.
> >
> > I didn't really touch the touch_nmi_watchdog() code in the kernel, so it
> > still calls a stub function in kernel/watchdog.c. Add a boolean to that
> > path and I think it accomplishes the logic you are looking for.
> >
> > Cheers,
> > Don
>
>
> Yeah looks good.
>
> Could you send this patch with a changelog and your sign-off?

I thought about including it when I refresh the patch series with the
other changes you suggested. Do you prefer it to be separate?

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/