Re: [PATCH 1/2] Composite framework: Add suspended sysfs entry

[Chouteau Fabien]

On Wed, Apr 21, 2010 at 8:05 PM, Greg KH <gregkh@xxxxxxx> wrote:
>
> On Wed, Apr 21, 2010 at 05:38:21PM +0200, fabien.chouteau@xxxxxxxxx wrote:
> > From: Fabien Chouteau <fabien.chouteau@xxxxxxxxx>
> >
> >
> > Signed-off-by: Fabien Chouteau <fabien.chouteau@xxxxxxxxx>
> > ---
> >  drivers/usb/gadget/composite.c |   21 +++++++++++++++++++++
> >  include/linux/usb/composite.h  |    1 +
> >  include/linux/usb/gadget.h     |    4 ++++
> >  3 files changed, 26 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> > index 09289bb..a5352f3 100644
> > --- a/drivers/usb/gadget/composite.c
> > +++ b/drivers/usb/gadget/composite.c
> > @@ -898,6 +898,18 @@ static void composite_disconnect(struct usb_gadget *gadget)
> >
> >  /*-------------------------------------------------------------------------*/
> >
> > +static ssize_t composite_show_suspended(struct device *dev,
> > +                                     struct device_attribute *attr,
> > +                                     char *buf)
>
> As you added a sysfs file, it is required that you also add an entry in
> Documentation/ABI/ that describes the file and what it is for.  Please
> respin this with that added to the patch.

ok,
is  "testing/sysfs-devices-platform-_UDC_-gadget" a good choice for
the file name?
("_UDC_" depends on the UDC driver name)

--
Fabien Chouteau
EPITA GISTR 2010
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/