Re: Fix OOPS in crash_kernel_shrink

From: Cong Wang
Date: Thu Apr 22 2010 - 04:27:01 EST


Vitaly Mayatskikh wrote:
At Tue, 20 Apr 2010 20:56:14 +0800, Cong Wang wrote:
Vitaly Mayatskikh wrote:
Two "echo 0 > /sys/kernel/kexec_crash_size" OOPSes kernel. Also
content of this file is invalid after first shrink to zero: it shows 1
instead of 0.

This patch fixes it.
Hmmm, I certainly did tests for 'echo 0 > kexec_crash_size' when I
worked on this, but I didn't get any oops. Can you show me the full
oops?

Do it twice. start == end condition will work over and over, and
kernel will try to release_resource() again (and that's causes OOPS).


Hmm, I see. ACK to your patch.

Thanks much!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/