Re: [PATCH V2] blkio: Fix blkio crash during rq stat update

From: Jens Axboe
Date: Wed Apr 21 2010 - 11:41:33 EST


On Wed, Apr 21 2010, Jens Axboe wrote:
> On Wed, Apr 21 2010, Vivek Goyal wrote:
> > @@ -1001,6 +1002,11 @@ static struct cfq_group *cfq_get_cfqg(struct cfq_data *cfqd, int create)
> > return cfqg;
> > }
> >
> > +static inline struct cfq_group *cfq_ref_get_cfqg(struct cfq_group *cfqg) {
> > + atomic_inc(&cfqg->ref);
> > + return cfqg;
> > +}
> > +
>
> Sorry to keep harping on this - style is still wrong, and:

I'll fix these up by hand.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/