Re: [PATCH] kbuild: add *.rej pattern to .gitignore

[Guennadi Liakhovetski]

On Wed, 21 Apr 2010, Américo Wang wrote:

> On Wed, Apr 21, 2010 at 01:47:29PM +0200, Guennadi Liakhovetski wrote:
> >Tell git to ignore .rej files, generated by patch(1).
> >
> >Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> 
> NACK.
> 
> You have to handle *.rej files, not leaving them there.

Hm? I know I have to handle them, and I do handle them, but IMHO it's 
entirely valid and up to the user to leave them where they are. You could 
apply similar argument to *.orig or to *~ files. In other words, I'm not 
convinced.

Thanks
Guennadi

> >---
> >diff --git a/.gitignore b/.gitignore
> >index a2939fc..17ababa 100644
> >--- a/.gitignore
> >+++ b/.gitignore
> >@@ -74,5 +74,6 @@ GSYMS
> > GTAGS
> > 
> > *.orig
> >+*.rej
> > *~
> > \#*#

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/