Re: [PATCH 0/4] enhanced reimplemention of the kfifo API

[Ira W. Snyder]

On Tue, Apr 20, 2010 at 01:16:42PM -0700, Greg KH wrote:
> On Tue, Apr 20, 2010 at 10:06:36PM +0200, stefani@xxxxxxxxxxx wrote:
> > From: Stefani Seibold <stefani@xxxxxxxxxxx>
> > 
> > This is a complete reimplementation of the new kfifo API, which is now 
> > really generic, type save and type definable. 
> > 
> > The API is still stable, no code which use the current  kfifo API must 
> > be modified!
> > 
> > Here are the results of the text section usage:
> > 
> > Example 1:
> >                         kfifo_put/_get  kfifo_in/out    current kfifo
> > dynamic allocated       0x000002a8      0x00000291      0x00000299
> > in place                0x00000291      0x0000026e      0x00000273
> > 
> > kfifo.c                 new             old
> > text section size       0x00000be5      0x000008b2
> > 
> > As you can see, kfifo_put/kfifo_get creates a little bit more code than 
> > kfifo_in/kfifo_out, but it is much faster (the code is inline).
> > 
> > The code is complete hand crafted and optimized. The text section size is as 
> > small as possible. You get all the fifo handling in only 3 kb. This includes 
> > type safe fix size records, dynamic records and DMA handling.
> > 
> > This should be the final version. All requested features are implemented.
> > 
> > Note: Most features of this API doesn't have any users. All functions which
> > are not used in the next 9 months will be removed. So, please adapt your
> > drivers and other sources as soon as possible to the new API and post it. 
> > 
> > This are the features which are currently not used in the kernel:
> > 
> > kfifo_to_user()
> > kfifo_from_user()
> > kfifo_dma_....() macros
> > kfifo_esize()
> > kfifo_recsize()
> > kfifo_put()
> > kfifo_get()
> > the fixed size record elements, exclude "unsigned char" fifo's and
> > the variable size records fifo's
> 
> If you have features that have no users, why add them?  Do you think
> that some drivers need/want these features?
> 

As a user who has been following this patch set for quite a while, I
have uses in my drivers for the kfifo_*_user() functions as well as well
as the kfifo_dma_*() functions.

I'm not especially comfortable developing against changes that aren't
upstream, especially the "core infrastructure" type changes. This is the
reason I haven't ported to the updated kfifo API yet. I hunch other
"small time" developers have the same worries.

Unfortunately, my drivers are not upstream, as they're for very custom
hardware, and would not be useful on anything outside of my lab. I'm
happy to send the source to anyone interested.

Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/