repost - RFC [Patch] Remove "please try 'cgroup_disable=memory'option if you don't want memory cgroups" printk at boot time.

From: Larry Woodman
Date: Tue Apr 20 2010 - 10:23:01 EST


Re-posting, cc'ing linux-mm as requested:

We are considering removing this printk at boot time from RHEL because
it will confuse customers, encourage them to change the boot parameters
and generate extraneous support calls. Its documented in
Documentation/kernel-parameters.txt anyway. Any thoughts???

Larry Woodman


diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c
index 3d535d5..2029fae 100644
--- a/mm/page_cgroup.c
+++ b/mm/page_cgroup.c
@@ -83,8 +83,6 @@ void __init page_cgroup_init_flatmem(void)
goto fail;
}
printk(KERN_INFO "allocated %ld bytes of page_cgroup\n", total_usage);
- printk(KERN_INFO "please try 'cgroup_disable=memory' option if you"
- " don't want memory cgroups\n");
return;
fail:
printk(KERN_CRIT "allocation of page_cgroup failed.\n");