Re: [PATCH RFC tip/core/rcu 10/16] rcu: slim down rcutiny by removing rcu_scheduler_active and friends

[David Howells]

Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx> wrote:

> +void rcu_scheduler_starting(void)
> +{
> +	WARN_ON(nr_context_switches() > 0);
> +	rcu_scheduler_active = 1;
> +}

Since rcu_scheduler_active is a global variable, does it make sense to make
this an inline function in the header file?

It looks decidedly odd in its own include file as you've done it.  Wouldn't
the right way to do this be to split it into its own .c file and conditionally
compile it in the Makefile?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/