Re: trace-cmd: make Makefile rpm-friendly

[Randy Dunlap]

On 04/19/10 12:06, Steven Rostedt wrote:
> On Mon, 2010-04-19 at 20:11 +0200, John Kacur wrote:
>>
>> On Mon, 19 Apr 2010, Randy Dunlap wrote:
>>
>>> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>>>
>>> Update Makefile to support rpmbuild DESTDIR usage.
>>
>> So, what would happen if you did
>> make DESTDIR=/usr/local install ?
>>
>> I think you would get /usr/local/usr/local
>> So, I think I would NAK this patch.
>>
>> I also don't believe there is anything magical about DESTDIR in a spec 
>> file. Essentially, prefix in this makefile is equivalent to DESTDIR, so 
>> you can replace DESTDIR with prefix in a spec template.
>>  
> 
> NAK is too strong. I was looking at what perf does, and it basically
> makes prefix and DESTDIR the same.
> 
> ifndef DESTDIR
> prefix = $(HOME)
> endif
> 
> We could do..
> 
> ifndef DESDIR
> prefix = /usr/local/bin
> endif
> 
> and then, if DESTDIR is not set, it would do the right thing.

Yes, thanks, but I have it "fixed" now (for some daffynition of fixed).

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/