Re: trace-cmd: make Makefile rpm-friendly

From: Randy Dunlap
Date: Mon Apr 19 2010 - 14:38:41 EST


On 04/19/10 11:11, John Kacur wrote:
>
>
> On Mon, 19 Apr 2010, Randy Dunlap wrote:
>
>> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>>
>> Update Makefile to support rpmbuild DESTDIR usage.
>
> So, what would happen if you did
> make DESTDIR=/usr/local install ?
>
> I think you would get /usr/local/usr/local
> So, I think I would NAK this patch.
>
> I also don't believe there is anything magical about DESTDIR in a spec
> file. Essentially, prefix in this makefile is equivalent to DESTDIR, so
> you can replace DESTDIR with prefix in a spec template.

I see. Thanks for your comments.

--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/