Re: [PATCH 1/5] Add a global synchronization point for pvclock

[Avi Kivity]

On 04/19/2010 02:05 PM, Peter Zijlstra wrote:
> > > ACCESS_ONCE() is your friend.
> > >
> > >        
> > I think it's implied with atomic64_read().
> >      
> Yes it would be. I was merely trying to point out that
>
>    last = ACCESS_ONCE(last_value);
>
> Is a narrower way of writing:
>
>    last = last_value;
>    barrier();
>
> In that it need not clobber all memory locations and makes it instantly
> clear what we want the barrier for.
>    

Oh yes, just trying to avoid a patch with both atomic64_read() and 
ACCESS_ONCE().



--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/