Re: [PATCH] usb: core: config.c: use buffer on stack rather then onheap

[Alan Stern]

On Sat, 17 Apr 2010, Michal Nazarewicz wrote:

> usb_get_configuration() uses a temporary buffer allocated on heap
> to read USB configuration descriptor.  The buffer is just nine
> bytes an so it is a waste to allocate it on heap where it can be
> allocated on stack with the rest of local variables.  This
> simplifies the code and minimises memory usage.

This is completely wrong.  You are not allowed to do DMA to buffers on 
the stack; some architectures are not capable of handling it.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/