Re: [PATCH] mac8390: fix pr_info() calls and change return code
From: Finn Thain
Date: Fri Apr 16 2010 - 09:57:44 EST
On Thu, 15 Apr 2010, Joe Perches wrote:
> ...Why is it better to use -EBUSY?
Nubus slots are geographically addressed and their irqs are equally
inflexible. -EAGAIN is misleading because retrying will not help fix
whatever bug caused the irq to unavailable.
> ...It'd be better to prefix this with the driver name
> or use something like netdev_dbg with #define DEBUG
> otherwise it's "huh? what device emits this message?"
> when reading the logs.
>
> Something like:
> printk(KERN_DEBUG pr_fmt("reset not supported\n"));
Thanks for the suggestion. I'll resend again.
> ...unnecessary conversion.
I guess some prefer consistency, some prefer symmetry.
Finn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/