Re: linux-next: PowerPC WARN_ON_ONCE() after merge of the finaltree (tip related)

From: Peter Zijlstra
Date: Fri Apr 16 2010 - 06:38:48 EST


On Thu, 2010-04-15 at 19:15 +0200, Frederic Weisbecker wrote:
> > that looks rather ugly. Why not do a raw:
> >
> > this_cpu_inc(lockdep_stats.redundant_hardirqs_on);
> >
> > which basically open-codes debug_atomic_inc(), but without the warning?
>
>
> Because that would open a race against interrupts that might
> touch lockdep_stats.redundant_hardirqs_on too.


How so, its a pure per-cpu variable right? so either the increment
happens before the interrupts hits, or after, in either case there
should not be a race with interrupts.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/