Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list()

[Andi Kleen]

Mel Gorman <mel@xxxxxxxxx> writes:
>
> $ stack-o-meter vmlinux-vanilla vmlinux-2-simplfy-shrink 
> add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-144 (-144)
> function                                     old     new   delta
> shrink_zone                                 1232    1160     -72
> kswapd                                       748     676     -72

And the next time someone adds a new feature to these code paths or
the compiler inlines differently these 72 bytes are easily there
again. It's not really a long term solution. Code is tending to get
more complicated all the time. I consider it unlikely this trend will
stop any time soon.

So just doing some stack micro optimizations doesn't really help 
all that much.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/