Re: [PATCH 1/4] hmc6352: Add driver for the HMC6352 compass

From: Alan Cox
Date: Thu Apr 15 2010 - 08:07:48 EST


> Argument alignment

Makes it take more space

> Spacing

Mostly dropped

> Make chars static

Not sure I see the point (compiler generates good code anyway)

> Remove prefixes from dev_<level> logging

Good point.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/