Re: [PATCH] block: blk-timeout.c ensure jiffies wrap is handledcorrectly in blk_rq_timed_out_timer

[Jens Axboe]

On Wed, Apr 14 2010, Richard Kennedy wrote:
> blk_rq_timed_out_timer() relied on blk_add_timer() never returning a
> timer value of zero, but commit 7838c15b8dd18e78a523513749e5b54bda07b0cb
> removed the code that bumped this value when it was zero.
> Therefore when jiffies is near wrap we could get unlucky & not set the
> timeout value correctly.
> 
> This patch uses a flag to indicate that the timeout value was set and so
> handles jiffies wrap correctly, and it keeps all the logic in one
> function so should be easier to maintain in the future. 

Thanks applied, it also makes it a bit clearer.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/