Re: [PATCH 2.6.34-rc4 1/8] mx5: Add registration of GPIOs for MX51Babbage board.

[Sascha Hauer]

On Wed, Apr 14, 2010 at 09:31:38AM +0200, Daniel Mack wrote:
> On Wed, Apr 14, 2010 at 08:51:31AM +0200, Sascha Hauer wrote:
> > On Tue, Apr 13, 2010 at 12:36:07PM -0700, Nguyen Dinh-R00091 wrote:
> > > > +
> > > > +#ifdef MXC_GPIO_SPLIT_IRQ_2
> > > 
> > > Where is that macro defined?
> > > [Dinh-FSL] - This macro is optional so that the interrupts can be broken
> > > up into 2 sets.
> > 
> > What's the purpose of doing so?
> > 
> > Such compile time depencies are not a good idea since the board may want
> > to decide whether to split the interrupts or not. Note that we support
> > kernels for more than one board.
> 
> And I would have expected at least one active user. As it stands, it's
> just dead code.

Ack, this should be removed. Anyone wanting this code will send a
seperate patch and can explain what and why he wants to do.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/