Re: [PATCH] USB: rename usb_buffer_alloc() and usb_buffer_free()

From: Greg KH
Date: Tue Apr 13 2010 - 16:26:26 EST


On Tue, Apr 13, 2010 at 03:27:36PM -0400, Alan Stern wrote:
> On Tue, 13 Apr 2010, Daniel Mack wrote:
>
> > On Mon, Apr 12, 2010 at 01:17:25PM +0200, Daniel Mack wrote:
> > > For more clearance what the functions actually do,
> > >
> > > usb_buffer_alloc() is renamed to usb_alloc_coherent()
> > > usb_buffer_free() is renamed to usb_free_coherent()
> > >
> > > They should only be used in code which really needs DMA coherency.
> > >
> > > All call sites have been changed accordingly, except for staging
> > > drivers.
> >
> > Is this ok? As it's quite big, I think it should be merged soon if there
> > are no objections.
>
> I have no objection. All it does is rename a couple of functions.
> There's no reason for this to go into 2.6.34; it can wait for the next
> merge window.

I think I will split this up into the following set of patches:
- rename the functions and add a macro for the old names
- rename all in-kernel usages
- rename the staging tree usages
- remove the macros

the first patch can go in to Linus's tree now, to make it easier for the
2nd and 3rd patches to live in linux-next easier as we might need to
look at the usages in other development trees before we can add the last
one.

Sound good?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/