Re: [PATCH 1/4] blkdev: pass gfp_mask and flags toblkdev_issue_flush

[Christoph Hellwig]

> +enum{
> +	__BLKDEV_IFL_WAIT,	/* wait for completion */
> +	__BLKDEV_IFL_BARRIER,	/*issue request with barrier */
> +};
> +#define BLKDEV_IFL_WAIT		(1 << __BLKDEV_IFL_WAIT)
> +#define BLKDEV_IFL_BARRIER	(1 << __BLKDEV_IFL_BARRIER)

This is a very awkward stayle to define flags.  There really should
be no need for the __-prefixed version.  While you're using them for
test/set_bit and co there's no reason to use these atomic bitops here.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/