Re: [PATCH 2/4] blkdev: generalize flags for blkdev_issue_fnfunctions

From: Christoph Hellwig
Date: Tue Apr 13 2010 - 14:05:16 EST


On Mon, Apr 12, 2010 at 05:03:55PM +0400, Dmitry Monakhov wrote:
> The patch just convert all blkdev_issue_xxx function to common
> flags. Wait/allocation semantics not changed.
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>

Looks good in general. But I would re-order this to be patch 1 so you
can avoid introducing flags for blkdev_issue_flush just to replace them
in the next one.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/