Re: [PATCH 54/64] alim15x3: fix handling of UDMA enable bit

From: Sergei Shtylyov
Date: Mon Apr 12 2010 - 09:54:36 EST


Bartlomiej Zolnierkiewicz wrote:
From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx>
Subject: [PATCH] alim15x3: fix handling of UDMA enable bit

Clear UDMA enable bit also for PIO modes.

Sorry for late mail but I fail to understand why this was done and what this patch fixes.

Based on libata pata_ali host driver.

libata has different mode programming code where first always the PIO mode and then DMA mode is set. With IDE core, the order can be different, PIO mode programming shouldn't affect DMA mode bits -- and does not affect it in the other drivers...

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/