Re: [PATCH] x86: Reserve legacy VGA MMIO area for x86_64 as wellas x86_32

From: Yinghai
Date: Fri Apr 09 2010 - 21:50:54 EST


On 04/09/2010 06:43 PM, Andy Isaacson wrote:
> On Fri, Apr 09, 2010 at 06:10:49PM -0700, Yinghai wrote:
>> in addition to -v2 patch
>>
>> please apply this patch too
>>
>> also please boot with "debug" in boot command line.
>>
>> Thanks
>>
>> Yinghai
>>
>> [PATCH] x86,acpi: use request_resource instead of instead of insert_resource
>>
>> So make pci root resouce from _CRS honor the one We reserve in e820 below 1M
>>
>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>>
>> ---
>> arch/x86/pci/acpi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: linux-2.6/arch/x86/pci/acpi.c
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/pci/acpi.c
>> +++ linux-2.6/arch/x86/pci/acpi.c
>> @@ -168,7 +168,7 @@ setup_resource(struct acpi_resource *acp
>> return AE_OK;
>> }
>>
>> - conflict = insert_resource_conflict(root, res);
>> + conflict = request_resource_conflict(root, res);
>> if (conflict) {
>> dev_err(&info->bridge->dev,
>> "address space collision: host bridge window %pR "
>
> That works. dmesg.gz attached (I'm pretty sure I'm skating close to
> vger's size limit without gz). "debug" didn't seem to make much
> difference?

[ 0.636805] ACPI: PCI Root Bridge [PCI0] (0000:00)
[ 0.654025] pci_root PNP0A03:00: address space collision: host bridge window [io 0x0000-0x0cf7] conflicts with dma1 [io 0x0000-0x001f]
[ 0.654370] pci_root PNP0A03:00: host bridge window [io 0x0d00-0xffff]
[ 0.654586] pci_root PNP0A03:00: address space collision: host bridge window [mem 0x000a0000-0x000bffff] conflicts with reserved [mem 0x000a0000-0x000fffff]
[ 0.654933] pci_root PNP0A03:00: address space collision: host bridge window [mem 0x000c0000-0x000effff] conflicts with reserved [mem 0x000a0000-0x000fffff]
[ 0.655002] pci_root PNP0A03:00: address space collision: host bridge window [mem 0x000f0000-0x000fffff] conflicts with reserved [mem 0x000a0000-0x000fffff]
[ 0.655367] pci_root PNP0A03:00: host bridge window [mem 0xf0000000-0xfebfffff]
[ 0.655706] pci_root PNP0A03:00: host bridge window [mem 0xbff00000-0xdfffffff]
[ 0.656003] pci_root PNP0A03:00: host bridge window [mem 0xff980800-0xff980bff]
[ 0.656360] pci_root PNP0A03:00: host bridge window [mem 0xff97c000-0xff97ffff]
[ 0.657002] pci_root PNP0A03:00: host bridge window [mem 0xfed20000-0xfed9ffff]

still not optimal.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/