Re: [PATCH 05/16] viafb: Determine type of 2D engine and store itin chip_info

[Florian Tobias Schandinat]

Jonathan Corbet schrieb:
> On Fri, 09 Apr 2010 05:20:28 +0200
> Florian Tobias Schandinat <FlorianSchandinat@xxxxxx> wrote:
>
> > Just a minor nit:
> > Could we change the default so that if someone adds support for a new 
> > IGP (and misses this function) we default to either the newest or 
> > preferably to none? I've just seen too much poorly maintained code in 
> > this driver and defaulting to the oldest is hence a bad idea.
> > Otherwise it's fine.
>
> That would require making an exhaustive list of older chipset types.
> It could probably be inferred through inspection of the code, but I
> worry about making assumptions in this area...

Such list already exists. gfx_chip_name = pdi->driver_data in hw.c (and 
only there) so what is needed is the list viafb_pci_table in viafbdev.c 
(relatively at the end) of all chips:
UNICHROME_CLE266
UNICHROME_PM800
UNICHROME_K400
UNICHROME_K800
UNICHROME_CN700
UNICHROME_K8M890
UNICHROME_CX700
UNICHROME_P4M900
UNICHROME_CN750
UNICHROME_VX800
UNICHROME_VX855

Would appreciate it if you could use this info.


Thanks,

Florian Tobias Schandinat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/