Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmasof a mergeable VMA

From: Rik van Riel
Date: Fri Apr 09 2010 - 16:05:18 EST


On 04/09/2010 03:32 PM, Linus Torvalds wrote:

Rik? I think it's back to you. I'm not going to bother committing the
change to the anon_vma locking unless you actually need the locking
guarantees for anon_vma_prepare().

And I've got the feeling that the proper fix is in the vma_adjust()
handling if your original idea was right.

We can fix it on the other side, by changing anon_vma_merge
to actually link all the anon_vma structs into the VMA.

An added benefit is that we are already holding the required
lock (mmap_sem) exclusively in that code path.

I'll cook up a patch and I'll mail it out after a little
testing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/